Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timing to 2PT matching service #346

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

Cruikshanks
Copy link
Member

https://eaflood.atlassian.net/browse/WATER-4046

We believe we have the matching algorithm to a point that covers all examples we have been asked to meet so far. We're also confident it will meet any new ones thrown at us!

So, if and when we do make changes we want to make sure we retain its current performance (5 secs to match all 2PT licences in Anglian; approximately 2,000).

To help us do that we are adding timing to the TwoPartService so we can keep an eye on it in the logs as we make further changes.

@Cruikshanks Cruikshanks added the enhancement New feature or request label Aug 9, 2023
@Cruikshanks Cruikshanks self-assigned this Aug 9, 2023
https://eaflood.atlassian.net/browse/WATER-4046

We believe we have the matching algorithm to a point that covers all examples we have been asked to meet so far. We're also confident it will meet any new ones thrown at us!

So, if and when we do make changes we want to make sure we retain its current performance (5 secs to match _all_ 2PT licences in Anglian; approximately 2,000).

To help us do that we are adding timing to the `TwoPartService` so we can keep an eye on it in the logs as we make further changes.
@Cruikshanks Cruikshanks force-pushed the check-2pt-performance branch from 5fbe4b3 to 69b60e3 Compare August 9, 2023 08:37
@Cruikshanks Cruikshanks marked this pull request as ready for review August 9, 2023 08:51
@Cruikshanks Cruikshanks requested a review from StuAA78 August 9, 2023 08:51
@Cruikshanks Cruikshanks merged commit 198e7ec into main Aug 9, 2023
@Cruikshanks Cruikshanks deleted the check-2pt-performance branch August 9, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants