Add crm_v2 to DatabaseHelper clean() method #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we added the first `crm_v2` schema models to our repo we forgot to added the schema to our `DatabaseHelper` and its `clean()` method. We use this to ensure the DB is empty of existing data before each test to ensure test isolation. This change adds the schema to the helper. Note - we also had to tweak the query to wrap the schema name in quotes. It's because PostgreSQL doesn't actually like the name because it is case sensitive 🤦😩. Without the quotes everything falls over.
Cruikshanks
added
the
housekeeping
Jozzey
previously approved these changes
Aug 4, 2023
StuAA78
requested changes
Aug 4, 2023
Co-authored-by: Stuart Adair <[email protected]>
StuAA78
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added the first
crm_v2schema models to our repo we forgot to add the schema to ourDatabaseHelperand itsclean()method.We use this to ensure the DB is empty of existing data before each test to ensure test isolation. This change adds the schema to the helper.
Note - we also had to tweak the query to wrap the schema name in quotes. It's because PostgreSQL doesn't actually like the name because it is case-sensitive 🤦😩. Without the quotes, everything falls over.