Improve reissuing error logging #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4036 We found that checking the logs for reissuing errors caused by the Charging Module returning an error response wasn't as straightforward as it could be; instead of having all the info logged in one error, we had to find the separately-logged CM error response to see why the request errored. This change adds the response body to our logged error so we don't need to go hunting for the reason for the error (eg. "Invoice has already been rebilled").
We break out the "check `responseBody`" assertions into their own tests and have the stubbed services return more realistic error responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4036
We found that checking the logs for reissuing errors caused by the Charging Module returning an error response wasn't as straightforward as it could be; instead of having all the info logged in one error, we had to find the separately-logged CM error response to see why the request errored. This change adds the response body to our logged error (as
responseBody) so we don't need to go hunting for the reason for the error (eg. "Invoice has already been rebilled").