Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix where supplementary billing service tests are #305

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

Cruikshanks
Copy link
Member

In Move supplementary-billing to new billing folder we did exactly that; move the supplementary billing services into a new app/services/billing/supplementary folder. Plus now we have a app/services/billing/two-part-tariff folder.

But for whatever reason, when we made that change we moved the tests to test/services/billing/supplementary-billing 🤦

This change fixes the inconsistency. 😬

In [Move supplementary-billing to new billing folder](#300) we did exactly that; move the supplementary billing services into a new `app/services/billing/supplementary` folder. Plus now we have a `app/services/billing/two-part-tariff` folder.

But for whatever reason, when we made that change we moved the tests to `test/services/billing/supplementary-billing` 🤦

This change fixes the inconsistency. 😬
@Cruikshanks Cruikshanks added the housekeeping Refactoring, tidying up or other work which supports the project label Jul 12, 2023
@Cruikshanks Cruikshanks self-assigned this Jul 12, 2023
@Cruikshanks Cruikshanks marked this pull request as ready for review July 12, 2023 16:46
@Cruikshanks Cruikshanks merged commit 23f86d9 into main Jul 12, 2023
@Cruikshanks Cruikshanks deleted the fix-supp-billing-test-location branch July 12, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant