Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node-sass from dependencies #28

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Remove node-sass from dependencies #28

merged 3 commits into from
Nov 15, 2022

Conversation

Cruikshanks
Copy link
Member

Recently, we Replaced node-sass with dart-sass package.

This meant removing the node-sass dependency. However, on a subsequent change (@Cruikshanks fault!) we managed to let it slip back in.

This corrects the mistake and removes node-sass from our dependencies.

Recently, we [Replaced node-sass with dart-sass package](#14).

This meant removing the node-sass dependency. However, on a [subsequent change](#8) (@Cruikshanks fault!) we managed to let it slip back in.

This corrects the mistake and removes node-sass from our dependencies.
@Cruikshanks Cruikshanks added the housekeeping Refactoring, tidying up or other work which supports the project label Nov 14, 2022
@Cruikshanks Cruikshanks self-assigned this Nov 14, 2022
Used `npm uninstall node-sass`.
@Cruikshanks Cruikshanks marked this pull request as ready for review November 14, 2022 13:46
@Cruikshanks Cruikshanks merged commit 4c152d0 into main Nov 15, 2022
@Cruikshanks Cruikshanks deleted the remove-node-sass branch November 15, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants