Fix isNewLicence null violation for prev. trans. #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had an issue reported that we were able to replicate locally. It looks like when we try to persist `billing_transactions` 'en masse' using Objection.js it behaves slightly differently than when inserting them in one by one. With our latest changes to to wait till we have generated _all_ the transactions for a billing period before persisting a new issue has come to light. ``` ... null value in column \"is_new_licence\" of relation \"billing_transactions\" violates not-null constraint" ... ``` After some debugging we found that our generated transactions wre ok. It was any previous transactions we had fetched and were trying to persist as credits. We weren't fetching `isNewLicence` because we were depending on it defaulting to false. It seems we must now fetch the property and ensure it is in the object when trying to persist them en masse.
Beckyrose200
approved these changes
May 25, 2023
StuAA78
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue reported that we were able to replicate locally. It looks like when we try to persist
billing_transactions'en masse' using Objection.js it behaves slightly differently than when inserting them in one by one.In our latest changes, where we now wait till we have generated all the transactions for a billing period before persisting them a new issue has come to light.
After some debugging, we found that our generated transactions were ok. It was any previous transactions we had fetched and were trying to persist as credits. We weren't fetching
isNewLicencebecause we were depending on it defaults to false. It seems we must now fetch the property and ensure it is in the object when trying to persist them en masse.