Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting table names from schema #237

Merged
merged 8 commits into from
May 22, 2023
Merged

Conversation

Beckyrose200
Copy link
Contributor

https://eaflood.atlassian.net/browse/WATER-4017

This pull request is just a small part of a larger project that involves exporting all our database schemas, converting them into CSV files, and uploading them to our Amazon S3 bucket. This PR's primary focus is to get the table names from the database using only the schema name provided. To expedite the export process and see the output sooner, we are using a vertical slicing approach, rather than a horizontal one, which means exporting a single table at a time from each schema.

https://eaflood.atlassian.net/browse/WATER-4017

This pull request is just a small part of a larger project that involves exporting all our database schemas, converting them into CSV files, and uploading them to our Amazon S3 bucket. This PR's primary focus is to get the table names from the database using only the schema name provided. To expedite the export process and see the output sooner, we are using a vertical slicing approach, rather than a horizontal one, which means exporting a single table at a time from each schema.
@Beckyrose200 Beckyrose200 added the enhancement New feature or request label May 22, 2023
@Beckyrose200 Beckyrose200 self-assigned this May 22, 2023
@Beckyrose200 Beckyrose200 marked this pull request as ready for review May 22, 2023 12:44
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some really minor formatting issues. But the meat of the change is all gravy!

app/services/db-export/fetch-table-names.service.js Outdated Show resolved Hide resolved
app/services/db-export/fetch-table-names.service.js Outdated Show resolved Hide resolved
@Beckyrose200 Beckyrose200 requested a review from Cruikshanks May 22, 2023 14:48
@Beckyrose200 Beckyrose200 merged commit 1830972 into main May 22, 2023
@Beckyrose200 Beckyrose200 deleted the getting-table-names-from-schema branch May 22, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants