Stop sending Airbrake notifications in tests #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotted when needing to go into [Errbit](https://errbit.com/) for another reason that we are sending real notifications when running our unit tests. This change ensures it's stubbed out where this is happening to avoid real notifications being sent.
Cruikshanks
added
the
housekeeping
This a little different from the others. When Boom was being called it was automatically outputting details of the error in our test output. This tweak silences the output but doesn't effect the behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted when needing to go into Errbit for another reason we are sending real notifications when running our unit tests.
This change ensures it's stubbed out where this is happening to avoid real notifications being sent. Also with this change, we remove the noise that appeared in our test output when working with errors.