Add prefix to 2PT billing transaction descriptions #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4006 It has been highlighted in testing that users expect to see a different description for any billing transactions linked to a charge version with a two-part tariff agreement in place. For example, a standard description would be > Water abstraction charge: Spray Irrigation at Baygrove Upcot Oldent If the charge version has a two-part tariff agreement it should be > Two-part tariff basic water abstraction charge: Spray Irrigation at Baygrove Upcot Oldent This change makes that happen.
We are not doing this for the isNewLicence arg. So, no need to do it for the isWaterUndertaker arg.
Just the way it was phrased seemed off; more like it should have been an `it()` block rather than a `describe()`.
We find it useful to use a plural where the result represents many things (typically arrays) and singular when `result` is a single instance of something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4006
It has been highlighted in testing that users expect to see a different description for any billing transactions linked to a charge version with a two-part tariff agreement in place.
For example, a standard description would be
If the charge version has a two-part tariff agreement it should be
This change makes that happen.
N.B. For reference, the legacy code handles this in
src/modules/billing/services/charge-processor-service/transactions-processor.js