Fix ProcessBillingBatchService refactor bug
#217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3996 After refactoring the `ProcessBillingBatchService` to fetch and store all invoice account numbers prior to the main loop, we found an issue where this could result in multiple billing invoices being generated for a single invoice account due to us generating a billing invoice for each and every charge version. We fix this by generating our billing invoices (one per invoice account) prior to entering the main loop. We then simply retrieve the pre-generated billing invoice within the loop.
Cruikshanks
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3996
After refactoring the
ProcessBillingBatchServiceto fetch and store all invoice account numbers prior to the main loop, we found an issue where this could result in multiple billing invoices being generated for a single invoice account due to us generating a billing invoice within the main loop, one for each charge version regardless of whether or not one was previously generated for the invoice account.We fix this by generating our billing invoices (one per invoice account) prior to entering the main loop. We then simply retrieve the pre-generated billing invoice within the loop.