Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

DEFRA / water-abstraction-system Public

Notifications You must be signed in to change notification settings
Fork 0
Star 1

Code
Pull requests 12
Actions
Security
Insights

Additional navigation options

Code
Pull requests
Actions
Security
Insights

Refactor `ProcessBillingBatchService` - first pass#214

Merged

StuAA78 merged 18 commits intomainDEFRA/water-abstraction-system:mainfrom refactor-process-billing-batch-service-first-passDEFRA/water-abstraction-system:refactor-process-billing-batch-service-first-passCopy head branch name to clipboard

May 11, 2023

+195-131

Conversation Commits18 (18)Checks Files changed

Commits

Commits on May 9, 2023

Refactor ProcessBillingBatchService - first pass
StuAA78
committed
Initial refactor
StuAA78
committed
Separate invoice and invoice licence data in loop
StuAA78
committed
Remove caching logic from GenerateBillingInvoiceService
StuAA78
committed
Separate fetching and generating invoice data
StuAA78
committed

Commits on May 10, 2023

Pull all invoice account data in a single query
StuAA78
committed
Handle errors in _fetchInvoiceData
StuAA78
committed
Refactor fetching into new FetchInvoiceAccountsService
StuAA78
committed
Remove unneeded 'generating the invoice data fails' test
StuAA78
committed
Remove .only
StuAA78
committed
Update GenerateBillingInvoiceService docs
StuAA78
committed
Amend FetchInvoiceAccountsService docs
StuAA78
committed
Amend invoice data structure
StuAA78
committed

Commits on May 11, 2023

Remove outdated comment
StuAA78
committed
Fetch invoice account numbers instead of invoice accounts
StuAA78
committed
Neaten up unit test
StuAA78
committed
Merge branch 'main' into refactor-process-billing-batch-service-first-pass
StuAA78
authored
Remove redundant awaits in unit test
StuAA78
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.