Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading file to AWS S3 bucket #211

Merged
merged 9 commits into from
May 12, 2023
Merged

Uploading file to AWS S3 bucket #211

merged 9 commits into from
May 12, 2023

Conversation

Beckyrose200
Copy link
Contributor

https://eaflood.atlassian.net/browse/WATER-3966

This pull request is just a small part of a larger project that involves exporting all our database schemas, converting them into CSV files, and uploading them to our Amazon S3 bucket. This PR's primary focus is connecting to the amazon s3 bucket and uploading the file. To expedite the export process and see the output sooner, we are using a vertical slicing approach, rather than a horizontal one, which means exporting a single table at a time from each schema.

https://eaflood.atlassian.net/browse/WATER-3966

This pull request is just a small part of a larger project that involves exporting all our database schemas, converting them into CSV files, and uploading them to our Amazon S3 bucket. This PR's primary focus is connecting to the amazon s3 bucket and uploading the file. To expedite the export process and see the output sooner, we are using a vertical slicing approach, rather than a horizontal one, which means exporting a single table at a time from each schema.
@Beckyrose200 Beckyrose200 added the housekeeping Refactoring, tidying up or other work which supports the project label May 4, 2023
@Beckyrose200 Beckyrose200 self-assigned this May 4, 2023
@Beckyrose200 Beckyrose200 marked this pull request as ready for review May 11, 2023 13:12
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it just needs a few tweaks. Shout if you need to chat through any of them!

app/services/db-export/send-to-s3-bucket.service.js Outdated Show resolved Hide resolved
app/services/db-export/send-to-s3-bucket.service.js Outdated Show resolved Hide resolved
app/services/db-export/send-to-s3-bucket.service.js Outdated Show resolved Hide resolved
test/services/db-export/send-to-s3-bucket.service.test.js Outdated Show resolved Hide resolved
test/services/db-export/send-to-s3-bucket.service.test.js Outdated Show resolved Hide resolved
Copy link
Contributor

@StuAA78 StuAA78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of suggested tweaks to the unit tests.

test/services/db-export/send-to-s3-bucket.service.test.js Outdated Show resolved Hide resolved
test/services/db-export/send-to-s3-bucket.service.test.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Jozzey Jozzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I see @Cruikshanks & @StuAA78 have a few things for you to look at. I can't see anything other than what they have found

Copy link
Contributor

@StuAA78 StuAA78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Beckyrose200 Beckyrose200 merged commit 1225599 into main May 12, 2023
@Beckyrose200 Beckyrose200 deleted the connect-to-s3 branch May 12, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Refactoring, tidying up or other work which supports the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants