Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support our unit testing we have a convention of creating ‘helpers’ that create the data we need to test our code.
Often data is related, for example, a
ChargeVersion
is linked to aLicence
record. When we first built the helpers we copied the model used by sroc-charging-module-api, which will create linked data records automatically.But as time went on, we realised the complexity of the WRLS data schema was making this pattern unworkable so we stopped. But our initial data helpers still follow that pattern. This has caused us to waste time or get confused at times when working on SROC supplementary billing.
So, before we start the next phase of work, we need to update the original helpers to stop creating linked records and update existing tests accordingly.