Fix supplementary bill run errors with non-chargeable charge versions #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3972 We found that an sroc supplementary bill run that contains a non-chargeable charge version would immediately error. On investigation we found that we were attempting to create invoices for these charge versions, starting by destructuring the `invoiceAccountId`, causing an error. Since we do not want to invocie these charge versions, we fix this by updating our db query to exclude records where `invoiceAccountId` is `null`.
When we retrieve charge versions in `FetchChargeVersionsService`, we want to exclude records which have a `null` value for `invoiceAccountId`. We therefore add a `.whereNotNull()` clause to our query.
Cruikshanks
approved these changes
Apr 19, 2023
StuAA78
deleted the
fix-erroring-bill-run-with-non-chargeable-charge-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3972
We found that an sroc supplementary bill run that contains a non-chargeable charge version would immediately error. On investigation we found that we were attempting to create invoices for these charge versions, starting by destructuring the
invoiceAccountId, causing an error.Since we do not want to invoice these charge versions at all, we fix this by updating our db query to exclude records where
invoiceAccountIdisnull.