Standardise how we test the length of an array #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our unit tests we had been checking the length of an array using the method `expect(result.length).to.equal(1)`. However our preferred way to test the length of an array is `expect(result).to.have.length(1)`. This PR updates all unit tests to use the `expect(result).to.have.length(1)` method to test the length of an array.
Jozzey
added
the
housekeeping
StuAA78
approved these changes
Apr 14, 2023
StuAA78
requested changes
Apr 14, 2023
test/services/supplementary-billing/fetch-charge-versions.service.test.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our unit tests we had been checking the length of an array using the method
expect(result.length).to.equal(1). However our preferred way to test the length of an array isexpect(result).to.have.length(1).This PR updates all unit tests to use the
expect(result).to.have.length(1)method to test the length of an array.