Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export billing_charge_categories #189

Merged
merged 10 commits into from
Apr 19, 2023
Merged

Export billing_charge_categories #189

merged 10 commits into from
Apr 19, 2023

Conversation

Beckyrose200
Copy link
Contributor

https://eaflood.atlassian.net/jira/software/c/projects/WATER/boards/96?modal=detail&selectedIssue=WATER-3963

This pull request is just a small part of a larger project that involves exporting all our database schemas, converting them into CSV files, and uploading them to our Amazon S3 bucket. Its primary focus is establishing a connection to the database and querying a specific table from the water schema. To expedite the export process and see the output sooner, we are using a vertical slicing approach, rather than a horizontal one, which means exporting a single table at a time from each schema.

https://eaflood.atlassian.net/jira/software/c/projects/WATER/boards/96?modal=detail&selectedIssue=WATER-3963

This pull request is just a small part of a larger project that involves exporting all our database schemas, converting them into CSV files, and uploading them to our Amazon S3 bucket. Its primary focus is establishing a connection to the database and querying a specific table from the water schema. To expedite the export process and see the output sooner, we are using a vertical slicing approach, rather than a horizontal one, which means exporting a single table at a time from each schema.
@Beckyrose200 Beckyrose200 added the enhancement New feature or request label Apr 12, 2023
@Beckyrose200 Beckyrose200 self-assigned this Apr 12, 2023
@Beckyrose200 Beckyrose200 marked this pull request as ready for review April 17, 2023 15:30
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine. Just some conventions you have not been exposed to suggesting some name changes.

Jozzey
Jozzey previously approved these changes Apr 18, 2023
Copy link
Contributor

@Jozzey Jozzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the exception of the issues @Cruikshanks has found it looks good. 👍🏼

@Beckyrose200 Beckyrose200 merged commit 70e4894 into main Apr 19, 2023
@Beckyrose200 Beckyrose200 deleted the export-table branch April 19, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants