Hack for supplementary billing being late #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SROC supplementary billing was always intended to be shipped for use in financial year 2022-23. We know at some point it will need to go back and look at previous years, as the PRE-SROC legacy version already does. But when we started this functionality was going to be added later. So, we wrote the current functionality to just look at the current financial year. That's a great idea when it's October 2022 and you aim to be done by Christmas! Fast forward to now, we're still plugging away and finding scenarios we've not covered or not handled (because we didn't know BTW). Which means we've fallen into the financial year 2023-24! 😱😱😱😱😱 As a hack, to allow us to ship supplementary billing and get the 2022-23 bills out and allow us to then move to multi-year billing we're hard coding the `BillingPeriodService` to always return 2022-23 (the first year of SROC's existence).
Cruikshanks
added
the
housekeeping
Jozzey
approved these changes
Apr 4, 2023
StuAA78
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SROC supplementary billing was always intended to be shipped for use in the financial year 2022-23. We know at some point it will need to go back and look at previous years, as the PRE-SROC legacy version already does. But when we started this functionality was going to be added later.
So, we wrote the current functionality to look at the current financial year. That's a great idea when it's October 2022 and you aim to be done by Christmas! Fast forward to now, we're still plugging away and finding scenarios we've not covered or not handled (because we didn't know BTW). This means we've fallen into the financial year 2023-24!
😱😱😱😱😱
As a hack, to allow us to ship supplementary billing and get the 2022-23 bills out and then move to multi-year billing we're hard-coding the
BillingPeriodServiceto always return 2022-23 (the first year of SROC's existence).