Handle no charge versions in ProcessBillingBatch #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
added
the
housekeeping
Cruikshanks
force-pushed
the
add-unit-tests-for-process-billing-batch
branch
from
71d8a78 to
c1bb80d
Compare
Cruikshanks
added
bug
Cruikshanks
changed the title
https://eaflood.atlassian.net/browse/WATER-3803 When we create the `ProcessBillingBatchService` we did it as a spike, as we were unsure of what the final service would look like. It's been through some changes since then, especially once we added support for crediting the previous billing batch in. But now we think we have a stable design that we will iterate rather than trash and re-write in future changes. So, as promised, it is time to start adding the missing unit tests.
Whilst thinking of the scenarios to test for ProcessBillingBatchService we though of one not currently tested for the ProcessBillingTransactionsService. What happens if we calculate no billable transactions but the previous billing batch does have transactions for the matching invoice and licence? Our current understanding is that we would credit everything on the previous bill run so our test ensures we get that result.
Again, we are not clear on how it could happen. But just in case we fetch no charge versions to bill we ensure we have protections for it in the service. We also add a unit test to document what we expect the service to do if this happens.
We've had to move around a lot of where things are getting created and stubbed. But now we have our first happy-path unit test that allows the process to complete.
Cruikshanks
force-pushed
the
add-unit-tests-for-process-billing-batch
branch
from
c1bb80d to
173b859
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3952
https://eaflood.atlassian.net/browse/WATER-3803
To be honest, this change started as our first effort to add unit test coverage for the
ProcessBillingBatchService. So, for example, our unit test error coverage now covers the changes we made including reversing the previous billing batch.Whilst working on them we realised we were not handling no charge versions being returned at all. So, we put in protection against this issue. Nice!
Only our QA has come across this issue in testing and needs it resolved so they can continue their work.
Hence, we're derailing the original intent of this PR and getting the fix to handle no charge versions returned (plus tests! 😬)