Refactor how we create transactions #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dropping the SROC because SROC is always assumed. Should we take on PRESROC functionality _then_ we'll label it as such. Replacing format with generate as we are 'generating' the transaction data from other data elements. It is also becoming our convention where a service is responsible for extracting data from other things to create a new object, but not persist it.
The charge period is based on the charge version and the billing period. So, when called within the transaction service we are just getting the same result. To avoid executing unnecessary code, we create the charge period outside the service and pass it in. This also means we can drop charge version as an arg to the service.
Until we are ready to implement the functionality and understand how the flag is determined, we'll just set it to false to simplify things.
We were already handling this one outside of the service. But as the number of options dwindles it's more verbose to specify it as an argument.
Trying to do everything just once which meant a whole re-jig of everything.
Cruikshanks
added
the
housekeeping
Group shorthand properties together at the top of an object declaration.
As suggested by the team.
Cruikshanks
force-pushed
the
refactor-format-transaction
branch
from
c238bd5 to
5f50dfc
Compare
StuAA78
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3906
Having implemented our Fix error calculating auth. and billable days we clocked that we were calculating charge periods, option flags, and the authorised and billable days multiple times, when they do not change between iterations of the charge elements in a charge version.
We only want to be executing our services when needed as it reduces complexity and the chance of an error occurring. It also means we get a slight performance bump.
So, this change refactors how the
ProcessBillingBatchServiceand theFormatSrocTransactionLineServiceinteract together to create the transaction lines for a billing batch.