Fix dupe bill. invoice licence in process service #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3906 Found in testing where we have a licence with multiple charge versions for the same invoice account we are handling reusing the billing invoice. But we are always trying to create a new billing invoice licence when we should be reusing them (when the Billing Invoice ID and licence ID are the same). So, this change updates the `app/services/supplementary-billing/create-billing-invoice-licence.service.js` to work in the same way as `app/services/supplementary-billing/create-billing-invoice.service.js`, fetching the existing billing invoice licence record if it exists else creating a new one.
StuAA78
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3906
Found in testing where we have a licence with multiple charge versions for the same invoice account we are handling reusing the billing invoice. But we are always trying to create a new billing invoice licence when we should be reusing them (when the Billing Invoice ID and licence ID are the same).
So, this change updates the
app/services/supplementary-billing/create-billing-invoice-licence.service.jsto work in the same way asapp/services/supplementary-billing/create-billing-invoice.service.js, fetching the existing billing invoice licence record if it exists else creating a new one.