Move determineChargePeriod() to a service #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3906 https://eaflood.atlassian.net/browse/WATER-3930 The charge period is the period of time that the charge version and its start and end date overlaps with the financial period being billed (01-Apr to 31-Mar). We need this period to then calculate how many billable days there are for the charge version. Currently, the `FormatSrocTransactionLineService` has this function. But we also need to know the charge period to [determine whether minimum charge applies](#149) to the charge version. So, this change moves the function out to a service we can then reuse in both places.
Cruikshanks
added
the
housekeeping
Now it can use our lovely new service
StuAA78
requested changes
Mar 6, 2023
app/services/supplementary-billing/determine-minimum-charge.service.js
Outdated
Show resolved
Hide resolved
StuAA78
previously approved these changes
Mar 6, 2023
Jozzey
previously approved these changes
Mar 6, 2023
Jozzey
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3906
https://eaflood.atlassian.net/browse/WATER-3930
The charge period is the period of time that the charge version and its start and end date overlap with the financial period being billed (01-Apr to 31-Mar). We need this period to then calculate how many billable days there are for the charge version.
Currently, the
FormatSrocTransactionLineServicehas this function. But we also need to know the charge period to determine whether minimum charge applies to the charge version.So, this change moves the function out to a service we can then reuse in both places.