Fix back link for copy existing in rtn vers setup #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4283 Spotted when prepping for a discussion about return versions setup that going back from the 'Use previous requirements for returns' page in the return version setup journey results in a 404. Basically, when we carried out a refactor to [Rename return-requirements route return-versions](#1431) we didn't spot that the back link had been built differently than all the other pages in the journey. So, it is still trying to go back to the defunct route. This changes fixes it.
This matches all the other presenters in the setup journey, all of which handle the backlink.
Cruikshanks
requested review from
robertparkinson,
Jozzey,
StuAA78,
jonathangoulding,
Beckyrose200 and
rvsiyad
rvsiyad
approved these changes
Nov 18, 2024
robertparkinson
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4283
We noticed when prepping for a discussion about return version setup that going back from the 'Use previous requirements for returns' page in the return version setup journey results in a 404.
Basically, when we carried out a refactor to Rename return-requirements route return-versions, we didn't spot that the backlink had been built differently than all the other pages in the journey.
So, it is still trying to go back to the defunct route. This change fixes it.