Start processing the billing batch from Initiate #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3906 https://eaflood.atlassian.net/browse/WATER-3929 To create the billing invoice, invoice licence, and transaction records during an SROC supplementary bill run we need to know the billing period we're generating the bill run for. This is determined in the `InitiateBillingBatchService` but not returned in its result. This change adds billing period to the result so we can it pass onto a new `ProcessBillingBatchService` (coming soon!)
Cruikshanks
added
the
housekeeping
This is what we have been working on in a spike and intend to be the service which manages the process of populating the bill run, the charging module's bill run, and handing the process back to the legacy code. We're adding this first so we can then call it from our InitiateBillingBatchService.
Now we have our placeholder service, we can make the necessary changes to InitiateBillingBatchService.
Cruikshanks
changed the title
Cruikshanks
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3906
https://eaflood.atlassian.net/browse/WATER-3929
Our
InitiateBillingBatchServicehandles creating the initial WRLS and Charging Module bill runs. It then returns information about both to the water-abstraction-service which makes the create bill run request.Using the same design as the charging-module-api, our intent is to perform a small action like this, and then return the result in less than a second. As the processing of the billing batch will take more than a second, this must happen in the background and not be something a user is left waiting for.
But we still need to kick it off and as the
InitiateBillingBatchServicehas all the data we need to do that this change updates the service to call a newProcessBillingBatchService.