New 'import' job to trigger return log and supplementary flag checks #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4728 This change adds a new 'import' job into the repo to trigger the work previously done to bring the legacy import logic. This change adds a new endpoint to be triggered from jenkins and will use the existing process licence service. There are a lot of licence refs to iterate over so a batching mechanism is used to reduce the load on the system.
jonathangoulding
added a commit
that referenced
this pull request
Oct 29, 2024
https://eaflood.atlassian.net/browse/WATER-4728 As part of ongoing work to migrate the legacy import logic into this repo, we are adding a trigger to enable us to start using this new logic - #1453 However, some of the logic needs to be turned off behind a feature flag so the other logic can go live. This import process was initially designed to be kicked off by the existing import service. This change will remove the route and controller for this older idea.
Cruikshanks
requested changes
Nov 6, 2024
|
Refactor added to move the process import licences into the import licences service. |
add performance test for importing licecnes
jonathangoulding
force-pushed
the
feature-import-job-to-trigger
branch
from
bb48ad5 to
7a85f7b
Compare
…import-job-to-trigger
add performance test for importing licecnes
add performance test for importing licecnes
Cruikshanks
added a commit
that referenced
this pull request
Dec 3, 2024
TBH, I'm still not clear when and how this service will get called. But the two scenarios I think we are looking at is - when a change happens with a licence - when [New 'import' job to trigger return log and supplementary flag checks](#1453) calls the service If it errors in the first scenario, we want it to blow up and the user to see it so they are not led to believe that the return logs have been generated. And if we can process 5K return logs in 3 secs, we should be able to handle a single licence in 1 sec, so I feel there is no need for the time to be logged. In the second instance, we'll be processing all 74K licences. We are only interested in those that have changed (end date added, removed or changed) but we normally see quite a number. In that case like the return logs job, we're more interested in the time for processing _all_ changed licences, not individual ones. And unlike the return logs job, it is acceptable that a return log creation failing blows up _this_ process, because we are just handling a single licence. It will be on the import job to ensure a licence blowing up doesn't prevent other licences from be processed.
Cruikshanks
added a commit
that referenced
this pull request
Dec 6, 2024
TBH, I'm still not clear when and how this service will get called. But the two scenarios I think we are looking at is - when a change happens with a licence - when [New 'import' job to trigger return log and supplementary flag checks](#1453) calls the service If it errors in the first scenario, we want it to blow up and the user to see it so they are not led to believe that the return logs have been generated. And if we can process 5K return logs in 3 secs, we should be able to handle a single licence in 1 sec, so I feel there is no need for the time to be logged. In the second instance, we'll be processing all 74K licences. We are only interested in those that have changed (end date added, removed or changed) but we normally see quite a number. In that case like the return logs job, we're more interested in the time for processing _all_ changed licences, not individual ones. And unlike the return logs job, it is acceptable that a return log creation failing blows up _this_ process, because we are just handling a single licence. It will be on the import job to ensure a licence blowing up doesn't prevent other licences from be processed.
| ProcessReturnLogsService.go(cycle) | ||
|
|
||
| if (h.request.payload !== null && h.request.payload.licenceReference) { |
There was a problem hiding this comment.
I think this might be a merge issue ?
i am not in the git blame @robertparkinson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4728
This change adds a new 'import' job into the repo to trigger the work previously done to bring the legacy import logic.
This change adds a new endpoint to be triggered from jenkins and will use the existing process licence service.
There are a lot of licence refs to iterate over so a batching mechanism is used to reduce the load on the system.