Fix testing endpoint for supplementary flags #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently a PR was raised to create a testing endpoint for the process of flagging a licence for supplementary billing during the import service. This looks at the licence end dates and works out what if any flags should be added to the licence. During testing the feature wasn't working as expected. After some investigation, it turns out that the testing endpoint wasn't confured correctly. When the arguments are passed in the body of the request it converts everything to String. This means the data we are mocking is in a String data type and not a Date data type, which it would be during the actual import. This PR fixed the object before being passed to the supplementary flagging process.
Beckyrose200
requested review from
Cruikshanks,
robertparkinson,
Jozzey and
rvsiyad
robertparkinson
approved these changes
Oct 23, 2024
Cruikshanks
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Can you update the PR description with a link to the relevant Jira ticket, and ensure it is included as part of the squashed merge?
https://eaflood.atlassian.net/browse/WATER-4591
All good though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4591
Recently, a PR was raised to create a testing endpoint for flagging a licence for supplementary billing during the import service. This process looks at the licence end dates and determines what flags should be added to the licence. During testing, the feature wasn't working as expected.
After some investigation, it turns out that the testing endpoint wasn't configured correctly. When the arguments are passed in the body of the request, it converts everything to a String. This means the data we are mocking is in a
Stringdata type and not aDatedata type. We need the object to be aDatetype as during the import that is what would be fetched from the db.This PR fixed the object before being passed to the supplementary flagging process.