Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create return cycle dates library #1436

Merged
merged 7 commits into from
Oct 22, 2024
Merged

create return cycle dates library #1436

merged 7 commits into from
Oct 22, 2024

Conversation

robertparkinson
Copy link
Collaborator

https://eaflood.atlassian.net/browse/WATER-4546

As part of the work to replace the legacy system NALD we need to generate return logs and return cycles. This PR creates a library for calculating dates related to return cycles and the unit tests to cover them.

@robertparkinson robertparkinson self-assigned this Oct 21, 2024
Cruikshanks
Cruikshanks requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for splitting this out. It's made reviewing the changes much easier.

And this means I have some feedback and suggested changes. Do let me know if you have any issues with them, or challenges.

app/lib/return-cycle-dates.lib.js Outdated Show resolved Hide resolved
app/lib/return-cycle-dates.lib.js Outdated Show resolved Hide resolved
app/lib/return-cycle-dates.lib.js Outdated Show resolved Hide resolved
app/lib/return-cycle-dates.lib.js Outdated Show resolved Hide resolved
test/lib/return-cycle-dates.lib.test.js Outdated Show resolved Hide resolved
Cruikshanks
Cruikshanks previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertparkinson robertparkinson merged commit c766461 into main Oct 22, 2024
3 of 4 checks passed
@robertparkinson robertparkinson deleted the return-cycle-dates-lib branch October 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cruikshanks Cruikshanks Cruikshanks left review comments

Assignees

@robertparkinson robertparkinson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertparkinson @Cruikshanks