Licence Import Supplementary billing test endpoint #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4591 Due to the fact the above ticket is happening during the licence import (which is automated), we need to add a test endpoint to allow the QA team to test the new supplementary flagging functionality. The process of flagging a licence for supplementary billing only happens if there is a new end date added to the licence (lapsed, expired or revoked). The imported licence is looking at NALD data, so built into our testing endpoint is functionality that means you can pass a new licence end date and it will act as though that is the imported NALD data.
Beckyrose200
requested review from
Cruikshanks,
robertparkinson,
Jozzey and
rvsiyad
|
Ignore Sonar Cloud complaining, there are no tests for this endpoint as it will only get deleted once the ticket has been tested by QA |
Cruikshanks
requested changes
Oct 21, 2024
Cruikshanks
requested changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4591
Due to the fact the above ticket is happening during the licence import (which is automated), we need to add a test endpoint to allow the QA team to test the new supplementary flagging functionality. The process of flagging a licence for supplementary billing only happens if there is a new end date added to the licence (lapsed, expired or revoked). The imported licence is looking at NALD data, so built into our testing endpoint is functionality that means you can pass a new licence end date and it will act as though that is the imported NALD data.