Add LegacyRequestLib #143
Merged
Add LegacyRequestLib #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3906 https://eaflood.atlassian.net/browse/WATER-3921 For the SROC supplementary bill run process we intend to take things as far as having the batch, invoice, invoice licence and transaction records created in the DB and the Charging Module API, and the bill run generated. Control will then be handed to the legacy service to complete the process. `src/modules/billing/jobs/create-charge.js` in the [water-abstraction-service](https://github.com/DEFRA/water-abstraction-service) has been our guide for this. After generating the bill run in the charging module it queues up the `src/modules/billing/jobs/refresh-totals.js` job. We've [added a new endpoint](DEFRA/water-abstraction-service#2036) to the **water-abstraction-service** that allows us to do the same. The first step is to add a new `LegacyRequestLib` following the same pattern as `app/lib/charging-module-request.lib.js`.
The legacy services use a shared [JSON Web Token (JWT)](https://jwt.io/) which is saved as an env var in their own config files. Requests need to have this set in their `authorisation` header or they'll be rejected. TBH, it is a pointless authentication mechanism! All the legacy services share the same token, and read it from config files stored on the server instances. From a security point of view, it's the same as keeping your password on a post-it note stuck to your monitor. But, Rome wasn't built in a day. So, for now, our new system has to play along.
Now we have it, we might as well use it in the existing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3906
https://eaflood.atlassian.net/browse/WATER-3921
For the SROC supplementary bill run process we intend to take things as far as having the batch, invoice, invoice licence and transaction records created in the DB and the Charging Module API, and the bill run generated.
Control will then be handed to the legacy service to complete the process.
src/modules/billing/jobs/create-charge.jsin the water-abstraction-service has been our guide for this. After generating the bill run in the charging module it queues up thesrc/modules/billing/jobs/refresh-totals.jsjob.We've added a new endpoint to the water-abstraction-service that allows us to do the same. The first step is to add a new
LegacyRequestLibfollowing the same pattern asapp/lib/charging-module-request.lib.js.As part of this change, we have to add a new env var to support talking to the legacy services. We also update our existing
app/services/health/info.service.jsto make use ofLegacyRequestLib.