Update some unit tests to use Model stubbing #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have found a pattern we can use to stub Objection Models in our unit tests. In this PR we are going use the model stubbing in some unit tests where it makes sense to so that we have some examples of the pattern being used in our code for future reference.
Jozzey
added
housekeeping
|
I didn't find any tests in which to stub models that would clearly demonstrate how the stubbing works. The ones I found are too simple, and the complex ones are generally in their own service and need to be tested properly. I'm therefore going to document model stubbing in our Team repo for future reference. |
Jozzey
requested review from
Cruikshanks,
robertparkinson,
Beckyrose200 and
rvsiyad
Beckyrose200
approved these changes
Oct 21, 2024
robertparkinson
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found a pattern we can use to stub Objection Models in our unit tests.
In this PR, we are going to use the model stubbing in some unit tests where it makes sense so that we have some examples of the pattern being used in our code for future reference.