Add PATCH support to our request lib modules #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3906 https://eaflood.atlassian.net/browse/WATER-3919 In order to call the [/generate](https://defra.github.io/sroc-charging-module-api-docs/#/bill-run/GenerateBillRun) bill run endpoint in the Charging Module API we need to be able to make `PATCH` http requests. This change adds the functionality to `app/lib/request.lib.js` and `app/lib/charging-module-request.lib.js`.
That is a little harsh. It does work, but it has now retry support from Got unlike the other types of requests. So, our retry tests fail. Good to know they are working as expected!
Cruikshanks
force-pushed
the
add-patch-support-to-requests
branch
from
70fc645 to
e096055
Compare
It is a personal preference that has become a convention in our tests. Executing the thing under test is done within the test rather than a `before()` block. IMHO when this isn't done it is easy to lose sight of what a test is testing as you add more and more unit tests. It does mean you get some duplication. But we think it makes for more readable code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3906
https://eaflood.atlassian.net/browse/WATER-3919
In order to call the /generate bill run endpoint in the Charging Module API we need to be able to make
PATCHHTTP requests.This change adds the functionality to
app/lib/request.lib.jsandapp/lib/charging-module-request.lib.js.Housekeeping
It is a personal preference that has become a convention in our tests. Executing the thing under test should be done within the test rather than a
before()block.It's our opinion when this isn't done you lose sight of what a test is testing as you add more and more unit tests. It does mean you get some duplication. But we think it makes for more readable code.
As we were adding new tests to
test/lib/charging-module-request.lib.test.jswe spotted this deviation and corrected it as part of this change.