Exclude VOID returns from two-part tariff billing #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4709 > Part of our work implementing SROC two-part tariff billing A request has come from our users after testing the current iteration of reviewing the matches and allocations for a two-part tariff return. They are satisfied we don't include VOID return logs in the allocation results. But they would rather we just exclude them from the process completely. Then we wouldn't see them in the results as they just seem to make things confusing. So, this change excludes VOID return logs (returns that have been replaced because of changes) from the two-part tariff match and allocate process.
Co-authored-by: Alan Cruikshanks <[email protected]> Co-authored-by: Becky Ransome <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4709
A request has come from our users after testing the current iteration of reviewing the matches and allocations for a two-part tariff return.
They are satisfied we don't include VOID return logs in the allocation results. But they would rather we exclude them from the process completely. Then, we wouldn't see them in the results, as they seem to make things confusing.
This change excludes VOID return logs (returns that have been replaced because of changes) from the two-part tariff match and allocate process.