Remove POST create bill run route #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
added
the
housekeeping
https://eaflood.atlassian.net/browse/WATER-4201 When we first added SROC supplementary billing to this project, creation of the bill run was triggered from [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui). Later, we've added SROC two-part tariff annual billing. That required a change to the create bill run journey, so we took the opportunity to migrate it to this project. This means we no longer expect the legacy UI to trigger bill runs. The end point it was using is now defunct. But also, it means we can simplify our bill run creation/initialisation logic because we no longer have to consider there being two trigger points. The thing we have been working on recently is SROC two-part tariff supplementary. We're ready to stitch all the pieces we've built together, the first step being triggering the bill run. Our journey now includes the option, but it hasn't been updated to check whether a user _can_ create a two-part tariff supplementary bill run (based on state of existing bill runs). That's going to complete the create/initiate process even further. So, as a preparatory step, we're simplifying things first by dropping the old POST create bill run route.
Cruikshanks
force-pushed
the
remove-post-create-bill-run
branch
from
6393d6e to
5df7d9f
Compare
It was only used by this defunct endpoint
Cruikshanks
requested review from
robertparkinson,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4201
When we first added SROC supplementary billing to this project, creation of the bill run was triggered from water-abstraction-ui.
Later, we added SROC two-part tariff annual billing. That required a change to the create bill run journey, so we took the opportunity to migrate it to this project.
This means we no longer expect the legacy UI to trigger bill runs. The endpoint it was using is now defunct. But also, it means we can simplify our bill run creation/initialisation logic because we no longer have to consider two trigger points.
We have been working on SROC two-part tariff supplementary recently. We're ready to stitch all the pieces we've built together, the first step being triggering the bill run. Our journey now includes the option, but it hasn't been updated to check whether a user can create a two-part tariff supplementary bill run (based on the state of existing bill runs).
That will complicate the create/initiate process even more. So, as a preparatory step, we're simplifying things first by dropping the old POST create bill run route.