Rename gauging stations to monitoring stations #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4679 When we first added gauging stations as a model to this project it was as part of our work to migrate the view licence page. On its summary tab it will display any gauging stations the licence is linked to. Though that's not really true! What it displays are the 'Monitoring stations' a licence is linked to. If you click through one that is listed, the page you'll see will be on the url `/monitoring-stations` (both legacy and ours). If you use the main search the results are displayed under the section title 'Monitoring stations'. When we did the migration of the view licence page, we did challenge why we still refer to them as 'Gauging stations' and whether we should be updating the UI to match. The answer we got back was that though 'Gauging stations' is commonly used by the users we speak to, they are only one type of station that we have in our system. So, when this feature was added it was agreed to use the generic term 'Monitoring stations'. What we now have is one of those discrepancies we often find in the legacy code which causes confusion. The DB and/or code is named differently to what we see in the UI. So, before we do anything too adventurous with them, this change updates anything named 'gauging station' to be 'monitoring station'.
Cruikshanks
added
the
housekeeping
Cruikshanks
added a commit
to DEFRA/water-abstraction-acceptance-tests
that referenced
this pull request
Oct 17, 2024
https://eaflood.atlassian.net/browse/WATER-4679 > See also [Rename gauging stations to monitoring stations](DEFRA/water-abstraction-system#1415) When we first added gauging stations as a model to this project it was as part of our work to migrate the view licence page. Its summary tab will display any gauging stations the licence is linked to. Though that's not really true! It displays the 'Monitoring stations' a licence is linked to. If you click through one that is listed, the page you'll see will be on the URL `/monitoring-stations` (both legacy and ours). The results are displayed under the section titled 'Monitoring stations' if you use the main search. When we migrated the view licence page, we challenged why we still refer to them as 'Gauging stations' and whether we should update the UI to match. The answer we got back was that though 'Gauging stations' is commonly used by the users we speak to, they are only one type of station that we have in our system. So, when this feature was added it was agreed to use the generic term 'Monitoring stations'. What we now have is one of those discrepancies we often find in the legacy code which causes confusion. The DB and/or code are named differently from what we see in the UI. So, before we do anything too adventurous with them, this change updates anything named 'gauging station' to be 'monitoring station'.
Cruikshanks
added a commit
to DEFRA/water-abstraction-acceptance-tests
that referenced
this pull request
Oct 17, 2024
https://eaflood.atlassian.net/browse/WATER-4679 > See also [Rename gauging stations to monitoring stations](DEFRA/water-abstraction-system#1415) When we first added gauging stations as a model to this project it was as part of our work to migrate the view licence page. Its summary tab will display any gauging stations the licence is linked to. Though that's not really true! It displays the 'Monitoring stations' a licence is linked to. If you click through one that is listed, the page you'll see will be on the URL `/monitoring-stations` (both legacy and ours). The results are displayed under the section titled 'Monitoring stations' if you use the main search. When we migrated the view licence page, we challenged why we still refer to them as 'Gauging stations' and whether we should update the UI to match. The answer we got back was that though 'Gauging stations' is commonly used by the users we speak to, they are only one type of station that we have in our system. So, when this feature was added it was agreed to use the generic term 'Monitoring stations'. What we now have is one of those discrepancies we often find in the legacy code which causes confusion. The DB and/or code are named differently from what we see in the UI. So, before we do anything too adventurous with them, this change updates anything named 'gauging station' to be 'monitoring station'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4679
When we first added gauging stations as a model to this project it was as part of our work to migrate the view licence page. Its summary tab will display any gauging stations the licence is linked to.
Though that's not really true! It displays the 'Monitoring stations' a licence is linked to. If you click through one that is listed, the page you'll see will be on the URL
/monitoring-stations(both legacy and ours). The results are displayed under the section titled 'Monitoring stations' if you use the main search.When we migrated the view licence page, we challenged why we still refer to them as 'Gauging stations' and whether we should update the UI to match.
The answer we got back was that though 'Gauging stations' is commonly used by the users we speak to, they are only one type of station that we have in our system. So, when this feature was added it was agreed to use the generic term 'Monitoring stations'.
What we now have is one of those discrepancies we often find in the legacy code which causes confusion. The DB and/or code are named differently from what we see in the UI.
So, before we do anything too adventurous with them, this change updates anything named 'gauging station' to be 'monitoring station'.