Fix auth scope on view monitoring station route #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4679 We are working through the legacy pages and migrating them to this new repo. We've been working on migrating the view monitoring station page; another issue was found during the latest round of QA. When we added the new route, we set the auth scope to `billing`. Clearly a copy and paste error, because when the legacy code is reviewed it has no scope. Like viewing a licence, all users should be able to view a monitoring station. Once in the page their role will determine whether they can do anything else with it. This change removes the scope to fix the issue.
rvsiyad
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4679
We are working through the legacy pages and migrating them to this new repo. We've been working on migrating the view monitoring station page; another issue was found during the latest round of QA.
When we added the new route, we set the auth scope to
billing. Clearly a copy and paste error, because when the legacy code is reviewed it has no scope.Like viewing a licence, all users should be able to view a monitoring station. Once in the page their role will determine whether they can do anything else with it.
This change removes the scope to fix the issue.