Add Charging Module generate bill run service #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once all the transactions have been added to the Charging Module bill run it needs to be [generated](https://defra.github.io/sroc-charging-module-api-docs/#/bill-run/GenerateBillRun). This is where it confirms the final values and calculates any additional transaction lines needed. So, in this change we add app/services/charging-module/generate-bill-run.service.js which will handle calling the `/generate` endpoint in the [sroc-charging-module-api](https://github.com/DEFRA/sroc-charging-module-api).
Cruikshanks
force-pushed
the
add-charging-module-generate-service
branch
from
c6e460c to
219fb0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3906
https://eaflood.atlassian.net/browse/WATER-3917
Once all the transactions have been added to the Charging Module bill run it needs to be generated. This is where it confirms the final values and calculates any additional transaction lines needed.
So, in this change, we add app/services/charging-module/generate-bill-run.service.js which will handle calling the
/generateendpoint in the sroc-charging-module-api.