Stop adding link on due returns for unauth users #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4444 We have built a replacement view licence page, which includes displaying return logs to all users. All users should be able to see return logs. But when we reviewed the legacy code we overlooked that only permitted users should see a link on 'due/overdue' returns that allows them to edit it. The issue was reported on behalf of users with basic access. When they were clicking the link they were seeing an error. We checked what the legacy page does and it simply doesn't display a link. So, this change updates our version to replicate this behaviour.
Cruikshanks
requested review from
robertparkinson,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
jonathangoulding
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4700
We have built a replacement view licence page, which includes displaying return logs to all users.
All users should be able to see return logs. However, when we reviewed the legacy code, we overlooked that only permitted users should see a link on 'due/overdue' returns that allows them to edit them.
The issue was reported on behalf of users with basic access. When they clicked the link, they saw an error. We checked what the legacy page does, and it simply doesn't display a link.
So, this change updates our version to replicate this behaviour.