Import company address data for a licence #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4669 We need to replace the import service logic to import a licence from NALD. The current import service iterates all the companies (known as parties in the import.NALD_PARTIES table) and updates CRM_V2 tables. This change will use the nald licence id and region to update the addresses' data. This will insert or update the company addresses record. This is not a concept in nald and is created for WRLS to link an address to company. We will insert this imported data in the relevant public views.
update process licence test to stub TransformCompanyAddressesService
…om/DEFRA/water-abstraction-system into import-company-address-for-licence
Cruikshanks
requested changes
Oct 4, 2024
app/services/import/legacy/transform-company-addresses.service.js
Outdated
Show resolved
Hide resolved
app/services/import/legacy/transform-company-addresses.service.js
Outdated
Show resolved
Hide resolved
app/services/import/legacy/transform-company-addresses.service.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
…ce' into import-company-address-for-licence
Cruikshanks
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4669
We need to replace the import service logic to import a licence from NALD.
The current import service iterates all the companies (known as parties in the import.NALD_PARTIES table) and updates CRM_V2 tables.
This change will use the nald licence id and region to update the addresses' data. This will insert or update the company addresses record.
This is not a concept in nald and is created for WRLS to link an address to company.
We will insert this imported data in the relevant public views.