Fix missing bill run number in batch #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cruikshanks
force-pushed
the
fix-missing-bill-run-number
branch
2 times, most recently
from
886d207 to
e3e09ac
Compare
https://eaflood.atlassian.net/browse/WATER-3906 We spotted during testing that the success page after confirming an SROC supplementary bill run displayed an `undefined` (This is in the [water-abstraction-ui](https://github.com/DEFRA/water-abstraction-ui)). What it should have been showing was the bill run number. This comes from the [Charging Module API](https://github.com/DEFRA/sroc-charging-module-api) in the response after creating the bill run. We found the legacy code saves this but we've overlooked it in our version. This change fixes this oversight.
Cruikshanks
force-pushed
the
fix-missing-bill-run-number
branch
from
e3e09ac to
7d40569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3906
https://eaflood.atlassian.net/browse/WATER-3916
We spotted during testing that the success page after confirming an SROC supplementary bill run displayed an
undefined(This is in the water-abstraction-ui). What it should have been showing was the bill run number.This comes from the Charging Module API in the response after creating the bill run. We found the legacy code saves this but we've overlooked it in our version.
This change fixes this oversight.
Screenshot of error