Include water.points in data tear down #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4600 https://eaflood.atlassian.net/browse/WATER-4645 > Part of the work to migrate return versions from NALD to WRLS In [Update the 'points' data solution](#1352) we updated this project to source point information (where water is extracted) from new tables we'd created instead of extracting it from the `permit.licence` JSONB blob. At the same time we included it in our data loader, which is used by [water-abstraction-acceptance-tests](https://github.com/DEFRA/water-abstraction-acceptance-tests). But we forgot to include it in the data tear down, which is also used by the acceptance tests to avoid orphaned test data causing other issues.
Cruikshanks
added
the
housekeeping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4600
https://eaflood.atlassian.net/browse/WATER-4645
In Update the 'points' data solution, we updated this project to source point information (where water is extracted) from new tables we'd created instead of extracting it from the
permit.licenceJSONB blob.At the same time we included it in our data loader, which is used by water-abstraction-acceptance-tests. But we forgot to include it in the data tear down, which is also used by the acceptance tests to avoid orphaned test data causing other issues.