Update Licence role helper to use reference data #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of ongoing work to seed reference data we have been updating the helpers to use the data we seed. This change will update the licence role helper to select the data for the licence role. It will default to licenceHolder and allow the default to be overridden when needed. This has been done as the majority of the current test use the licence holder role.
jonathangoulding
deleted the
test-update-licence-role-helper-to-use-reference-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4579
As part of ongoing work to seed reference data we have been updating the helpers to use the data we seed.
This change will update the licence role helper to select the data for the licence role.
It will default to licenceHolder and allow the default to be overridden when needed. This has been done as the majority of the current test use the licence holder role.