Licence import flagging for supplementary billing #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4591 During the licence import process we need to check if a licence has been lapsed/revoked or ended. A licence can end at any time, either in the past or the future. If the licence has ended in the past then the licence bills will be incorrect. This means the licence will need to be flagged for either pre sroc supplementary billing, sroc supplementary billing or two-part tariff supplementary billing (depending on what is affected). This PR is building the service needed to check the licence lapsed/revoked or ended date and flagging if necessary.
Cruikshanks
requested changes
Oct 11, 2024
app/services/import/determine-supplementary-billing-flags.service.js
Outdated
Show resolved
Hide resolved
app/services/import/determine-supplementary-billing-flags.service.js
Outdated
Show resolved
Hide resolved
app/services/licences/supplementary/process-imported-licence.service.js
Outdated
Show resolved
Hide resolved
test/services/licences/supplementary/fetch-existing-licence-details.service.test.js
Outdated
Show resolved
Hide resolved
test/services/licences/supplementary/fetch-existing-licence-details.service.test.js
Show resolved
Hide resolved
test/services/licences/supplementary/persist-supplementary-billing-flags.service.test.js
Outdated
Show resolved
Hide resolved
test/services/licences/supplementary/process-imported-licence.service.test.js
Outdated
Show resolved
Hide resolved
Cruikshanks
previously approved these changes
Oct 21, 2024
app/services/import/determine-supplementary-billing-flags.service.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4591
During the licence import process, we need to check if a licence has been lapsed/revoked or ended. A licence can end at any time, either in the past or the future. If the licence has ended in the past then the licence bills will be incorrect. This means the licence will need to be flagged for either pre-sroc supplementary billing, sroc supplementary billing or two-part tariff supplementary billing (depending on what is affected). This PR is building the service needed to check the licence lapsed/revoked or ended date and flagging if necessary.