Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend supplementary billing editing return journey #1320

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

Beckyrose200
Copy link
Contributor

https://eaflood.atlassian.net/browse/WATER-4589

During testing for the above ticket, it was noticed that if an edited return straddled the pre sroc and sroc financial years then no years where being persisted for the licence supplementary years table. This change allows the correct sroc years to be added to the table.

https://eaflood.atlassian.net/browse/WATER-4589

During testing for the above ticket, it was noticed that if an edited return straddled the pre sroc and sroc financial years then no years where being persisted for the licence supplementary years table. This change allows the correct sroc years to be added to the table.
@Beckyrose200 Beckyrose200 added the bug Something isn't working label Sep 10, 2024
@Beckyrose200 Beckyrose200 self-assigned this Sep 10, 2024
@Beckyrose200 Beckyrose200 marked this pull request as ready for review September 10, 2024 15:34
Copy link
Contributor

@Jozzey Jozzey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Beckyrose200 Beckyrose200 merged commit 2ce4dd7 into main Sep 10, 2024
6 checks passed
@Beckyrose200 Beckyrose200 deleted the supp-billing-flag-editing-return branch September 10, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants