Import contact data for a licence #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4667 We need to replace the import service logic to import a licence from NALD. The current import service iterates all the companies (known as parties in the import.NALD_PARTIES table) and updates CRM_V2 tables. This change will use the nald licence id and region to update the companies (parties) contact data. This means going forwards we will only import companies (parties) contact when the licence is imported. We will insert this imported data in the relevant public views. This change focuses on the companies (parties) contact data and not address or contacts tables which will be done after this work.
jonathangoulding
commented
Sep 9, 2024
jonathangoulding
commented
Sep 9, 2024
jonathangoulding
changed the title
| .insert({ ...contact, updatedAt }) | ||
| .onConflict('externalId') | ||
| .merge([ | ||
| 'salutation', |
There was a problem hiding this comment.
Should this update the data source to nald ? what if this has changed in wrls. Might be a none issue as the test helper sets this as wrls.
Cruikshanks
requested changes
Sep 23, 2024
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Co-authored-by: Alan Cruikshanks <[email protected]>
Cruikshanks
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4667
We need to replace the import service logic to import a licence from NALD.
The current import service iterates all the companies (known as parties in the import.NALD_PARTIES table) and updates CRM_V2 tables.
This change will use the nald licence id and region to update the companies (parties) contact data. This means going forwards we will only import companies (parties) contact when the licence is imported.
We will insert this imported data in the relevant public views.
This change focuses on the companies (parties) contact data and not address or contacts tables which will be done after this work.