Fix import licence log silencer #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4575 > Part of the work to replace the legacy licence import in readiness for ReSP Argh! We've done it again! We made a change to [Ignore new /import/licence endpoint in logs](#1275) so the logs became silent again instead of outputting 80K requests! But then in [Import Licence versions](#1195) we tweaked the route, and guess what we forgot to do! 😱🤦 This change updates the `HapiPinoIgnoreRequest` with the updated route.
Also fix the test by sending the right request through.
Cruikshanks
requested review from
robertparkinson,
Jozzey,
jonathangoulding,
Beckyrose200 and
rvsiyad
robertparkinson
approved these changes
Sep 6, 2024
jonathangoulding
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4575
Argh! We've done it again! We made a change to Ignore new /import/licence endpoint in logs, so the logs became silent again instead of outputting 80K requests!
But then in Import Licence versions we tweaked the route, and guess what we forgot to do! 😱🤦
This change updates the
HapiPinoIgnoreRequestwith the updated route.