Create seeder for charge_categories
#1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently with the way data is being inserted into `charge_categories` using the helper to create records during unit testing. We are getting intermittent failures when running the unit tests when the charge `reference` gets duplicated due to it's lack of randomness. We have therefore decided that since the data in `charge_categories` is reference data we shouldn't really be creating a new charge category records each time a unit test requires one. Instead we should just be seeding the data once and then writing the unit tests to use this seeded data. The bulk of this work has been done for other tables in this PR #1230
Jozzey
added
the
housekeeping
I pulled the first lot of seed data from my local DB then figured it would be better to get it from Pre-prod
The amount of data that is in the `charge_categories` table now that the data is seeded is causing this test to hang. Switching to the `regions` table that has less data in resolves the issue.
I initially removed `DatabaseSupport.clean()` from the test files that I updated. However this appeared to open a bit of a can of worms. Whilst the tests that I'd amended ran fine it was having an effect on other tests causing intermittent failures. So I think it's best to leave removing the DB cleanup for another PR.
Jozzey
requested review from
Cruikshanks,
robertparkinson,
jonathangoulding and
Beckyrose200
robertparkinson
approved these changes
Sep 11, 2024
| @@ -0,0 +1,33 @@ | |||
| 'use strict' | |||
|
|
|||
| const { timestampForPostgres } = require('../../app/lib/general.lib.js') | |||
There was a problem hiding this comment.
Just a nit, I think this needs to be below line 5
| * - `maxVolume` - 5000, | ||
| * - `dateCreated` - Date.now() | ||
| * So, they are seeded automatically when tests are run. Tests that need to link to a record can use this method to | ||
| * select a specific entry, or have it it return one at random. |
There was a problem hiding this comment.
Suggested change
| * select a specific entry, or have it it return one at random. | |
| * select a specific entry, or have it return one at random. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, with the way data is being inserted into
charge_categoriesusing the helper to create records during unit testing. We are getting intermittent failures when running the unit tests when the chargereferencegets duplicated due to its lack of randomness.We have therefore decided that since the data in
charge_categoriesis reference data we shouldn't be creating new charge category records each time a unit test requires one. Instead, we should just be seeding the data once and then writing the unit tests to use this seeded data. The bulk of this work has been done for other tables in this PR #1230This PR will create the functions required to seed the
charge_categoriesand then fix any code affected by this change.