Add relation mapping to LicenceModel
#1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4587 In order to get the data required to display the two-part tariff supplementary banner the query in `app/services/licences/fetch-licence.service.js` is going to be updated to include data from the `licence_supplementary_years` table. However, whilst there is currently a relation mapping to the 'LicenceModel' from the `LicenceSupplementaryYearModel`. There is no relation mapping to the `LicenceSupplementaryYearModel` from the `LicenceModel` so it will be added in this PR.
Jozzey
requested review from
Cruikshanks,
robertparkinson,
jonathangoulding,
Beckyrose200 and
rvsiyad
Cruikshanks
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4587
In order to get the data required to display the two-part tariff supplementary banner, the query in
app/services/licences/fetch-licence.service.jsis going to be updated to include data from thelicence_supplementary_yearstable.However, whilst there is currently a relation mapping to the 'LicenceModel' from the
LicenceSupplementaryYearModel. There is no relation mapping to theLicenceSupplementaryYearModelfrom theLicenceModel. This mapping will be added in this PR.