Import company data for a licence #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4649 We need to replace the import service logic to import a licence from NALD. The current import service iterates all the companies (known as parties in the import.NALD_PARTIES table) and updates CRM_V2 tables. This change will use the nald licence id and region to update the companies (parties) data. This means going forwards we will only import companies (parties) when the licence is imported. We will insert this imported data in the relevant public views. This change focuses on the companies (parties) data and not address or contacts tables which will be done after this work.
jonathangoulding
force-pushed
the
import-company-for-licence
branch
from
529f77c to
47da65a
Compare
jonathangoulding
commented
Sep 4, 2024
need to add a migration to add external id to the companies
jonathangoulding
commented
Sep 5, 2024
update wording to company and companies add remove duplicate companies from transformed companies
jonathangoulding
commented
Sep 5, 2024
jonathangoulding
commented
Sep 5, 2024
test/services/import/legacy/transform-companies.service.test.js
Outdated
Show resolved
Hide resolved
Cruikshanks
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4649
We need to replace the import service logic to import a licence from NALD.
The current import service iterates all the companies (known as parties in the import.NALD_PARTIES table) and updates CRM_V2 tables.
This change will use the nald licence id and region to update the company data. This means going forwards we will only import company when the licence is imported.
We will insert this imported data in the relevant public views.
This change focuses on the company data and not address or contacts tables which will be done after this work.