Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix licence agreements recalculate link bug #1303

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Conversation

Beckyrose200
Copy link
Contributor

#1291

During a recent bug fix for the view-licence presenter, we removed some data from the presenter that we thought was redundant to it. This data is needed, so this PR is adding it back in thus fixing some broken functionality that was created by removing it (mainly the recalculate bills link showing for a licence agreement).

#1291

During a recent bug fix for the view-licence presenter, we removed some data from the presenter that we thought was redundant to it. This data is actually needed, so this PR is adding it back in thus fixing some broken functionality that was created by removing it (mainly the recalculate bills link showing for a licence agreement).
@Beckyrose200 Beckyrose200 added the bug Something isn't working label Sep 2, 2024
@Beckyrose200 Beckyrose200 self-assigned this Sep 2, 2024
@Beckyrose200 Beckyrose200 marked this pull request as ready for review September 2, 2024 15:55
Copy link
Member

@Cruikshanks Cruikshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving the PR that fixes what you broke

@Beckyrose200 Beckyrose200 merged commit a386f84 into main Sep 2, 2024
6 checks passed
@Beckyrose200 Beckyrose200 deleted the agreements-bug branch September 2, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants