Flag licence for 2pt supplementary through recalculating bills #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4589 This PR is for rebuilding the recalculating bills pages for marking a licence as two-part tariff supplementary. Due to an extra page being added to the journey, the decision was made to rebuild the existing pages rather than try and insert a page from our system repo.
Beckyrose200
force-pushed
the
recalculate-bills-2pt
branch
from
d4190ce to
73eae2a
Compare
Jozzey
requested changes
Sep 11, 2024
test/presenters/licences/supplementary/mark-for-supplementary-billing.presenter.test.js
Outdated
Show resolved
Hide resolved
app/services/licences/supplementary/submit-mark-for-supplementary-billing.service.js
Show resolved
Hide resolved
app/services/licences/supplementary/submit-mark-for-supplementary-billing.service.js
Show resolved
Hide resolved
|
Question for @Cruikshanks The two-part tariff supplementary bill runs journey is now hidden behind a feature flag. Does the 'recalculate link' need to be the same? The functionality all works and the existing supplementary flagging all works, it's just in a different place and the users obviously can't run a 2pt supp bill run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4589
This PR is for rebuilding the recalculating bill's pages for marking a licence as a two-part tariff supplementary. Due to an extra page being added to the journey, the decision was made to rebuild the existing pages rather than try and insert a page from our system repo.