-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create test supplementary end point #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-3787 To help us perform testing we are going to create an endpoint that dispays the charge versions that are selected. The first step of this is to create an endpoint that outputs dummy data.
Jozzey
approved these changes
Nov 1, 2022
StuAA78
reviewed
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StuAA78
approved these changes
Nov 1, 2022
Cruikshanks
added a commit
that referenced
this pull request
Jul 10, 2023
https://eaflood.atlassian.net/browse/WATER-4038 Way back when we first started the work on SROC Supplementary billing we [started with a `/test` endpoint](#13). We used this as a means of triggering our billing engine and exposing the results, until such time as we were ready to integrate it into the process for real. We're about ready to start developing the next bill run type, which is two-part tariff (2PT) and we want to do the same again. Overtime we learnt things were much less confusing if the endpoint was actually `/check` (testing `TestService` in the `test/services/test` folder - need we say more!) So, this change adds the endpoint back into the repo. We can then start iterating our 2PT engine, verifying the results along the way.
Cruikshanks
added a commit
that referenced
this pull request
Jul 11, 2023
https://eaflood.atlassian.net/browse/WATER-4038 Way back when we first started the work on SROC Supplementary billing we [started with a `/test` endpoint](#13). We used this as a means of triggering our billing engine and exposing the results, until such time as we were ready to integrate it into the process for real. We're about ready to start developing the next bill run type, which is two-part tariff (2PT) and we want to do the same again. Over time we learnt things were much less confusing if the endpoint was actually `/check` (testing `TestService` in the `test/services/test` folder - need we say more!) So, this change adds the endpoint back into the repo. We can then start iterating our 2PT engine, verifying the results along the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-3787
To help us perform testing we are going to create an endpoint that dispays the charge versions that are selected. The first step of this is to create an endpoint that outputs dummy data.